Messages in this thread | | | Subject | Re: [PATCH 1/2] clk: bcm2835: Fix return type of bcm2835_register_gate | From | Stephen Boyd <> | Date | Tue, 26 May 2020 16:42:04 -0700 |
| |
Quoting Nathan Chancellor (2020-05-16 01:08:06) > bcm2835_register_gate is used as a callback for the clk_register member > of bcm2835_clk_desc, which expects a struct clk_hw * return type but > bcm2835_register_gate returns a struct clk *. > > This discrepancy is hidden by the fact that bcm2835_register_gate is > cast to the typedef bcm2835_clk_register by the _REGISTER macro. This > turns out to be a control flow integrity violation, which is how this > was noticed. > > Change the return type of bcm2835_register_gate to be struct clk_hw * > and use clk_hw_register_gate to do so. This should be a non-functional > change as clk_register_gate calls clk_hw_register_gate anyways but this > is needed to avoid issues with further changes. > > Fixes: b19f009d4510 ("clk: bcm2835: Migrate to clk_hw based registration and OF APIs") > Link: https://github.com/ClangBuiltLinux/linux/issues/1028 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > ---
Thanks. Applied to clk-next.
> > base-commit: bdecf38f228bcca73b31ada98b5b7ba1215eb9c9
Please don't base on some random linux-next commit though.
| |