Messages in this thread | | | Date | Tue, 26 May 2020 16:36:42 -0600 | From | Rob Herring <> | Subject | Re: [RESEND][V5 PATCH 1/2] dt-bindings: Added device tree binding for max98390 |
| |
On Mon, May 18, 2020 at 09:49:30AM +0900, Steve Lee wrote: > Add documentation for DT binding of max98390 amplifier driver. > > Signed-off-by: Steve Lee <steves.lee@maximintegrated.com> > --- > > > Changed since V4: > * No changes. > Changed since V3: > * No changes. > Changed since V2: > * No changes. > Changed since V1: > * Modified sample text in example
You are obviously sending patches too quickly. Give folks a chance to review.
> > .../devicetree/bindings/sound/max98390.txt | 26 +++++++++++++++++++
Bindings are now in DT schema format. Please convert this. See Documentation/devicetree/writing-schema.rst
> 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/max98390.txt > > diff --git a/Documentation/devicetree/bindings/sound/max98390.txt b/Documentation/devicetree/bindings/sound/max98390.txt > new file mode 100644 > index 000000000000..0ddd4c6ae55e > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/max98390.txt > @@ -0,0 +1,26 @@ > +Maxim Integrated MAX98390 Speaker Amplifier > + > +This device supports I2C. > + > +Required properties: > + > + - compatible : "maxim,max98390" > + > + - reg : the I2C address of the device. > + > +Optional properties: > + > +- maxim,temperature_calib > + u32. The calculated temperature data was measured while doing the calibration. Data : Temp / 100 * 2^12 > + > +- maxim,r0_calib > + u32. This is r0 calibration data which was measured in factory mode.
Unless these are shared already with other Maxim chips, s/_/-/.
> + > +Example: > + > +codec: max98390@38 {
amplifier@38
> + compatible = "maxim,max98390"; > + reg = <0x38>; > + maxim,temperature_calib = <1024>; > + maxim,r0_calib = <100232>; > +}; > -- > 2.17.1 >
| |