lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 16/19] mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo()
    Date
    memcg_accumulate_slabinfo() is never called with a non-root
    kmem_cache as a first argument, so the is_root_cache(s) check
    is redundant and can be removed without any functional change.

    Signed-off-by: Roman Gushchin <guro@fb.com>
    Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
    ---
    mm/slab_common.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/mm/slab_common.c b/mm/slab_common.c
    index c045afb9724e..52164ad0f197 100644
    --- a/mm/slab_common.c
    +++ b/mm/slab_common.c
    @@ -1087,9 +1087,6 @@ memcg_accumulate_slabinfo(struct kmem_cache *s, struct slabinfo *info)
    struct kmem_cache *c;
    struct slabinfo sinfo;

    - if (!is_root_cache(s))
    - return;
    -
    c = memcg_cache(s);
    if (c) {
    memset(&sinfo, 0, sizeof(sinfo));
    --
    2.25.4
    \
     
     \ /
      Last update: 2020-05-26 23:43    [W:2.827 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site