lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 18/59] component: Silence bind error on -EPROBE_DEFER
    Date
    From: James Hilliard <james.hilliard1@gmail.com>

    [ Upstream commit 7706b0a76a9697021e2bf395f3f065c18f51043d ]

    If a component fails to bind due to -EPROBE_DEFER we should not log an
    error as this is not a real failure.

    Fixes messages like:
    vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517
    vc4-drm soc:gpu: master bind failed: -517

    Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
    Link: https://lore.kernel.org/r/20200411190241.89404-1-james.hilliard1@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/base/component.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/base/component.c b/drivers/base/component.c
    index 08da6160e94d..55f0856bd9b5 100644
    --- a/drivers/base/component.c
    +++ b/drivers/base/component.c
    @@ -162,7 +162,8 @@ static int try_to_bring_up_master(struct master *master,
    ret = master->ops->bind(master->dev);
    if (ret < 0) {
    devres_release_group(master->dev, NULL);
    - dev_info(master->dev, "master bind failed: %d\n", ret);
    + if (ret != -EPROBE_DEFER)
    + dev_info(master->dev, "master bind failed: %d\n", ret);
    return ret;
    }

    @@ -431,8 +432,9 @@ static int component_bind(struct component *component, struct master *master,
    devres_release_group(component->dev, NULL);
    devres_release_group(master->dev, NULL);

    - dev_err(master->dev, "failed to bind %s (ops %ps): %d\n",
    - dev_name(component->dev), component->ops, ret);
    + if (ret != -EPROBE_DEFER)
    + dev_err(master->dev, "failed to bind %s (ops %ps): %d\n",
    + dev_name(component->dev), component->ops, ret);
    }

    return ret;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-05-26 21:30    [W:4.440 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site