lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 066/111] apparmor: Fix use-after-free in aa_audit_rule_init
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    commit c54d481d71c6849e044690d3960aaebc730224cc upstream.

    In the implementation of aa_audit_rule_init(), when aa_label_parse()
    fails the allocated memory for rule is released using
    aa_audit_rule_free(). But after this release, the return statement
    tries to access the label field of the rule which results in
    use-after-free. Before releasing the rule, copy errNo and return it
    after release.

    Fixes: 52e8c38001d8 ("apparmor: Fix memory leak of rule on error exit path")
    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Signed-off-by: John Johansen <john.johansen@canonical.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    security/apparmor/audit.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/security/apparmor/audit.c
    +++ b/security/apparmor/audit.c
    @@ -197,8 +197,9 @@ int aa_audit_rule_init(u32 field, u32 op
    rule->label = aa_label_parse(&root_ns->unconfined->label, rulestr,
    GFP_KERNEL, true, false);
    if (IS_ERR(rule->label)) {
    + int err = PTR_ERR(rule->label);
    aa_audit_rule_free(rule);
    - return PTR_ERR(rule->label);
    + return err;
    }

    *vrule = rule;

    \
     
     \ /
      Last update: 2020-05-26 21:24    [W:2.158 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site