lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 116/126] rxrpc: Fix a memory leak in rxkad_verify_response()
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    commit f45d01f4f30b53c3a0a1c6c1c154acb7ff74ab9f upstream.

    A ticket was not released after a call of the function
    "rxkad_decrypt_ticket" failed. Thus replace the jump target
    "temporary_error_free_resp" by "temporary_error_free_ticket".

    Fixes: 8c2f826dc3631 ("rxrpc: Don't put crypto buffers on the stack")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: David Howells <dhowells@redhat.com>
    cc: Markus Elfring <Markus.Elfring@web.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/rxrpc/rxkad.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/net/rxrpc/rxkad.c
    +++ b/net/rxrpc/rxkad.c
    @@ -1148,7 +1148,7 @@ static int rxkad_verify_response(struct
    ret = rxkad_decrypt_ticket(conn, skb, ticket, ticket_len, &session_key,
    &expiry, _abort_code);
    if (ret < 0)
    - goto temporary_error_free_resp;
    + goto temporary_error_free_ticket;

    /* use the session key from inside the ticket to decrypt the
    * response */
    @@ -1230,7 +1230,6 @@ protocol_error:

    temporary_error_free_ticket:
    kfree(ticket);
    -temporary_error_free_resp:
    kfree(response);
    temporary_error:
    /* Ignore the response packet if we got a temporary error such as

    \
     
     \ /
      Last update: 2020-05-26 21:17    [W:4.458 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site