lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 096/126] iio: sca3000: Remove an erroneous get_device()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit 928edefbc18cd8433f7df235c6e09a9306e7d580 upstream.

    This looks really unusual to have a 'get_device()' hidden in a 'dev_err()'
    call.
    Remove it.

    While at it add a missing \n at the end of the message.

    Fixes: 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iio/accel/sca3000.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/iio/accel/sca3000.c
    +++ b/drivers/iio/accel/sca3000.c
    @@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3
    st->tx[0] = SCA3000_READ_REG(reg_address_high);
    ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer));
    if (ret) {
    - dev_err(get_device(&st->us->dev), "problem reading register");
    + dev_err(&st->us->dev, "problem reading register\n");
    return ret;
    }


    \
     
     \ /
      Last update: 2020-05-26 21:15    [W:4.310 / U:0.900 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site