Messages in this thread | | | Subject | Re: [PATCH] drivers: ipa: print dev_err info accurately | From | Alex Elder <> | Date | Mon, 25 May 2020 19:49:25 -0500 |
| |
On 5/25/20 1:29 AM, Wang Wenhu wrote: > Print certain name string instead of hard-coded "memory" for dev_err > output, which would be more accurate and helpful for debugging. > > Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com> > Cc: Alex Elder <elder@kernel.org>
Good idea.
Reviewed-by: Alex Elder <elder@linaro.org>
> --- > drivers/net/ipa/ipa_clock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c > index ddbd687fe64b..749ff5668e37 100644 > --- a/drivers/net/ipa/ipa_clock.c > +++ b/drivers/net/ipa/ipa_clock.c > @@ -66,8 +66,8 @@ ipa_interconnect_init_one(struct device *dev, const char *name) > > path = of_icc_get(dev, name); > if (IS_ERR(path)) > - dev_err(dev, "error %ld getting memory interconnect\n", > - PTR_ERR(path)); > + dev_err(dev, "error %ld getting %s interconnect\n", > + PTR_ERR(path), name); > > return path; > } >
| |