Messages in this thread | | | Subject | Re: [PATCH v2 08/18] nitro_enclaves: Add logic for enclave vm creation | From | "Paraschiv, Andra-Irina" <> | Date | Mon, 25 May 2020 23:53:13 +0300 |
| |
On 22/05/2020 10:08, Greg KH wrote: > On Fri, May 22, 2020 at 09:29:36AM +0300, Andra Paraschiv wrote: >> Add ioctl command logic for enclave VM creation. It triggers a slot >> allocation. The enclave resources will be associated with this slot and >> it will be used as an identifier for triggering enclave run. >> >> Return a file descriptor, namely enclave fd. This is further used by the >> associated user space enclave process to set enclave resources and >> trigger enclave termination. >> >> The poll function is implemented in order to notify the enclave process >> when an enclave exits without a specific enclave termination command >> trigger e.g. when an enclave crashes. >> >> Signed-off-by: Alexandru Vasile <lexnv@amazon.com> >> Signed-off-by: Andra Paraschiv <andraprs@amazon.com> >> --- >> drivers/virt/nitro_enclaves/ne_misc_dev.c | 169 ++++++++++++++++++++++ >> 1 file changed, 169 insertions(+) >> >> diff --git a/drivers/virt/nitro_enclaves/ne_misc_dev.c b/drivers/virt/nitro_enclaves/ne_misc_dev.c >> index e1866fac8220..1036221238f4 100644 >> --- a/drivers/virt/nitro_enclaves/ne_misc_dev.c >> +++ b/drivers/virt/nitro_enclaves/ne_misc_dev.c >> @@ -63,6 +63,146 @@ struct ne_cpu_pool { >> >> static struct ne_cpu_pool ne_cpu_pool; >> >> +static int ne_enclave_open(struct inode *node, struct file *file) >> +{ >> + return 0; >> +} > Again, if a file operation does nothing, don't even provide it.
I removed open() in v3.
Thank you.
Andra
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
| |