lkml.org 
[lkml]   [2020]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] pwm: jz4740: Enhance precision in calculation of duty cycle
On Mon, May 25, 2020 at 02:57:20PM +0200, Paul Cercueil wrote:
> Calculating the hardware value for the duty from the hardware value of
> the period resulted in a precision loss versus calculating it from the
> clock rate directly.
>
> (Also remove a cast that doesn't really need to be here)
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>
> Notes:
> v2: New patch. I don't consider this a fix but an enhancement, since the old
> behaviour was in place since the driver was born in ~2010, so no Fixes tag.

I would not hesitate and add:

Fixes: f6b8a5700057 ("pwm: Add Ingenic JZ4740 support")

Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks for picking this up,
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

\
 
 \ /
  Last update: 2020-05-25 17:38    [W:0.036 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site