lkml.org 
[lkml]   [2020]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador
From
Date
Hi Andreas,

Em 5/25/20 7:41 AM, Andreas Färber escreveu:
> Hi,
>
> Am 25.05.20 um 03:30 schrieb Matheus Castello:
>> Update the documentation to add the Caninos Loucos Labrador. Labrador
>> project consists of a computer on module based on the Actions Semi S500
>> processor and the Labrador base board.
>>
>> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>>   Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml
>> b/Documentation/devicetree/bindings/arm/actions.yaml
>> index ace3fdaa8396..2187e1c5bc73 100644
>> --- a/Documentation/devicetree/bindings/arm/actions.yaml
>> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
>> @@ -19,6 +19,11 @@ properties:
>>                 - allo,sparky # Allo.com Sparky
>>                 - cubietech,cubieboard6 # Cubietech CubieBoard6
>>             - const: actions,s500
>> +      - items:
>> +          - enum:
>> +              - caninos,labrador-v2 # Labrador Core v2
>> +              - caninos,labrador-base-m # Labrador Base Board M v1
>
> This enum still strikes me as wrong, it means either-or. (Was planning
> to look into it myself, but no time yet...) caninos,labrador-v2 should
> be a const one level down: board, SoM, SoC from most specific to most
> generic. Compare Guitar below.

I got it, I agree make sense, I will send the v6.

>
>> +          - const: actions,s500
>>         - items:
>>             - enum:
>>                 - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board
>> rev. B
>
> Regards,
> Andreas
>

Best Regards,
Matheus Castello

\
 
 \ /
  Last update: 2020-05-25 15:00    [W:0.123 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site