Messages in this thread Patch in this message | | | From | Fabien DESSENNE <> | Subject | Re: [PATCH] media: bdisp: Fix runtime PM imbalance on error | Date | Mon, 25 May 2020 12:41:18 +0000 |
| |
Hi,
Looks good to me.
Reviewed-by: Fabien Dessenne <fabien.dessenne@st.com>
BR
Fabien
On 21/05/2020 12:00 pm, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > index af2d5eb782ce..e1d150584bdc 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > @@ -1371,7 +1371,7 @@ static int bdisp_probe(struct platform_device *pdev) > ret = pm_runtime_get_sync(dev); > if (ret < 0) { > dev_err(dev, "failed to set PM\n"); > - goto err_dbg; > + goto err_pm; > } > > /* Filters */ > @@ -1399,7 +1399,6 @@ static int bdisp_probe(struct platform_device *pdev) > bdisp_hw_free_filters(bdisp->dev); > err_pm: > pm_runtime_put(dev); > -err_dbg: > bdisp_debugfs_remove(bdisp); > err_v4l2: > v4l2_device_unregister(&bdisp->v4l2_dev); | |