Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 25 May 2020 13:46:43 +0200 | Subject | Re: [PATCH 6/8] soc: ux500: Use custom soc attribute group instead of device_create_file |
| |
On Sat, May 23, 2020 at 7:09 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
> Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried to use it, it was found lot of existing custom > attributes can moved to use it instead of device_create_file. > > Though most of these never remove/cleanup the custom attribute as they > never call soc_device_unregister, using these custom attribute group > eliminate the need for any cleanup as the driver infrastructure will > take care of that. > > Let us remove device_create_file and start using the custom attribute > group in soc_device_attribute. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |