Messages in this thread | | | Date | Mon, 25 May 2020 04:11:14 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH v2 2/7] radix-tree: Use local_lock for protection |
| |
On Mon, May 25, 2020 at 08:29:54AM +0200, Ingo Molnar wrote: > > +void radix_tree_preload_end(void) > > +{ > > + local_unlock(&radix_tree_preloads.lock); > > +} > > +EXPORT_SYMBOL(radix_tree_preload_end); > > Since upstream we are still mapping the local_lock primitives to > preempt_disable()/preempt_enable(), I believe these uninlining changes should not be done > in this patch, i.e. idr_preload_end() and radix_tree_preload_end() should stay inline.
But radix_tree_preloads is static, and I wouldn't be terribly happy to see that exported to modules.
| |