lkml.org 
[lkml]   [2020]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 07/45] powerpc/ptdump: Limit size of flags text to 1/2 chars on PPC32
From
Date


Le 25/05/2020 à 07:15, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@csgroup.eu> writes:
>> In order to have all flags fit on a 80 chars wide screen,
>> reduce the flags to 1 char (2 where ambiguous).
>
> I don't love this, the output is less readable. Is fitting on an 80 char
> screen a real issue for you? I just make my terminal window bigger.

I don't have strong opinion about that, and the terminal can be made bigger.
I just don't like how messy it is, some flags are so big that they hide
other ones and getting it more ordered and more compact helped me during
all the verifications I did with this series, but we can leave it as is
if you prefer.

Would you like a v5 without patches 7 and 8 ? Or I can just resend the
patches that will be impacted, that is 9 and 38 ?

Without the changes I get:

---[ Start of kernel VM ]---
0xc0000000-0xc0ffffff 0x00000000 16M huge shared r X
present accessed
0xc1000000-0xc7ffffff 0x01000000 112M huge shared rw
present dirty accessed
---[ vmalloc() Area ]---
0xc9000000-0xc9003fff 0x050e4000 16K shared rw
present dirty accessed
0xc9008000-0xc900bfff 0x050ec000 16K shared rw
present dirty accessed
0xc9010000-0xc9013fff 0xd0000000 16K shared rw
present guarded dirty accessed no cache
0xc9018000-0xc901bfff 0x050f0000 16K shared rw
present dirty accessed

---[ Fixmap start ]---
0xf7f00000-0xf7f7ffff 0xff000000 512K huge shared rw
present guarded dirty accessed no cache
---[ Fixmap end ]---
---[ kasan shadow mem start ]---
0xf8000000-0xf8ffffff 0x07000000 16M huge shared rw
present dirty accessed
0xf9000000-0xf91fffff [0x01288000] 16K shared r
present accessed
0xf9200000-0xf9203fff 0x050e0000 16K shared rw
present dirty accessed


With the change I get.

---[ Start of kernel VM ]---
0xc0000000-0xc0ffffff 0x00000000 16M h r x p sh
a
0xc1000000-0xc7ffffff 0x01000000 112M h rw p sh
d a
---[ vmalloc() Area ]---
0xc9000000-0xc9003fff 0x050e4000 16K rw p sh
d a
0xc9008000-0xc900bfff 0x050ec000 16K rw p sh
d a
0xc9010000-0xc9013fff 0xd0000000 16K rw p i g sh
d a
0xc9018000-0xc901bfff 0x050f0000 16K rw p sh
d a

---[ Fixmap start ]---
0xf7f00000-0xf7f7ffff 0xff000000 512K h rw p i g sh
d a
---[ Fixmap end ]---
---[ kasan shadow mem start ]---
0xf8000000-0xf8ffffff 0x07000000 16M h rw p sh
d a
0xf9000000-0xf91fffff [0x01288000] 16K r p sh
a
0xf9200000-0xf9203fff 0x050e0000 16K rw p sh
d a


Christophe

>
> cheers
>
>
>> No cache is 'i'
>> User is 'ur' (Supervisor would be sr)
>> Shared (for 8xx) becomes 'sh' (it was 'user' when not shared but
>> that was ambiguous because that's not entirely right)
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>> ---
>> arch/powerpc/mm/ptdump/8xx.c | 33 ++++++++++++++++---------------
>> arch/powerpc/mm/ptdump/shared.c | 35 +++++++++++++++++----------------
>> 2 files changed, 35 insertions(+), 33 deletions(-)

\
 
 \ /
  Last update: 2020-05-25 13:06    [W:0.277 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site