Messages in this thread | | | From | Marc Zyngier <> | Subject | Re: [PATCH] irqchip/gic-v2, v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs | Date | Mon, 25 May 2020 11:02:59 +0100 |
| |
On Thu, 21 May 2020 23:35:00 +0100, Valentin Schneider wrote: > (E)PPIs are per-CPU interrupts, so we want each CPU to go and enable them > via enable_percpu_irq(); this also means we want IRQ_NOAUTOEN for them as > the autoenable would lead to calling irq_enable() instead of the more > appropriate irq_percpu_enable(). > > Calling irq_set_percpu_devid() is enough to get just that since it trickles > down to irq_set_percpu_devid_flags(), which gives us IRQ_NOAUTOEN (and a > few others). Setting IRQ_NOAUTOEN *again* right after this call is just > redundant, so don't do it. > > [...]
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/gic-v2, v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs commit: cc86432aa8cc5a81f99d79eea2a29099da694df3
Cheers,
M. -- Without deviation from the norm, progress is not possible.
| |