lkml.org 
[lkml]   [2020]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support
On Thu, May 21, 2020 at 10:43:58AM +1000, Matt Jolly wrote:
> Add support for Dell Wireless 5816e Download Mode (AKA boot & hold mode /
> QDL download mode) to drivers/usb/serial/qcserial.c
>
> This is required to update device firmware.
>
> Signed-off-by: Matt Jolly <Kangie@footclan.ninja>
> ---
> v2 changes: typo.

Hmm. I'd a call a build breakage a bit more than just a "typo" as it
indicates this patch was never tested at all before being submitted.

Not good.

> ---
> drivers/usb/serial/qcserial.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index ce0401d3137f..d147feae83e6 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -173,6 +173,7 @@ static const struct usb_device_id id_table[] = {
> {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */
> {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */
> {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */
> + {DEVICE_SWI(0x413c, 0x81cb)}, /* Dell Wireless 5816e QDL */
> {DEVICE_SWI(0x413c, 0x81cc)}, /* Dell Wireless 5816e */
> {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */
> {DEVICE_SWI(0x413c, 0x81d0)}, /* Dell Wireless 5819 */

Now applied, though.

Johan

\
 
 \ /
  Last update: 2020-05-25 11:41    [W:0.041 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site