lkml.org 
[lkml]   [2020]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()
From
Date


On 2020/5/25 15:36, Markus Elfring wrote:
>> Could you help me to make the sentence better?
>
> How do you think about a wording variant like the following?
>
> So the system will crash when this memory will be used again.
>
Uh, it's much better, thanks.

>
>>> * You proposed to move a call of the function “crypto_finalize_skcipher_request”.
>>> How does this change fit to the mentioned position?
>>>
>> The resources which need to be freed is not used anymore, but the pointers
>> of these resources may be changed in the function
>> "crypto_finalize_skcipher_request", so free these resources before call the
>> function is suitable.
>
> Another alternative:
> The resources which need to be cleaned up are not used any more.
> But the pointers of these resources may be changed in the
> function “crypto_finalize_skcipher_request”.
> Thus release specific resources before calling this function.
>
Oh great! Thanks.

> Regards,
> Markus
>

--
---
Regards,
Longpeng(Mike)

\
 
 \ /
  Last update: 2020-05-25 10:04    [W:0.038 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site