Messages in this thread | | | Subject | Re: [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe(). | From | Sylwester Nawrocki <> | Date | Sun, 24 May 2020 21:27:21 +0200 |
| |
On 5/24/20 21:03, Sylwester Nawrocki wrote: > On 5/24/20 05:46, wu000273@umn.edu wrote: >> From: Qiushi Wu <wu000273@umn.edu> >> >> "pm_runtime_enable()" was not handled by "pm_runtime_disable()" >> after a call of the function “pm_runtime_get_sync()” failed. >> Thus move the jump target “err_pm” before calling function >> "calling pm_runtime_disable()". >> >> Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC >> series camera interface") >> Signed-off-by: Qiushi Wu <wu000273@umn.edu> >> --- >> >> V2: improving commit messages. > > Thanks for the patch. It seems you have got typo in the subject line. > With tegra_adma_probe changed to s3c_camif_probe feel free to add: > > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
I just noticed this patch https://patchwork.linuxtv.org/patch/63976 which includes your fix and handles one more issue. Thus it might be better to apply the patch from Dinghao Liu instead.
| |