Messages in this thread | | | Subject | Re: [PATCH] printk: Remove pr_cont_once() | From | Joe Perches <> | Date | Sun, 24 May 2020 11:49:34 -0700 |
| |
On Mon, 2020-05-25 at 00:32 +0900, Tetsuo Handa wrote: > pr_cont_once() does not make sense; at least emitting module name using > pr_fmt() into middle of a line (after e.g. pr_info_once()) does not make > sense. Let's remove unused pr_cont_once().
Right, thanks.
It's nearly a decade old cut'n'paste defect and no one has ever used it or noticed it until now.
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Cc: Joe Perches <joe@perches.com> > --- > include/linux/printk.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/printk.h b/include/linux/printk.h > index 2562ffb438ed..4c565871f659 100644 > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -476,8 +476,7 @@ extern int kptr_restrict; > printk_once(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__) > #define pr_info_once(fmt, ...) \ > printk_once(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) > -#define pr_cont_once(fmt, ...) \ > - printk_once(KERN_CONT pr_fmt(fmt), ##__VA_ARGS__) > +/* no pr_cont_once, don't do that... */ > > #if defined(DEBUG) || defined(CONFIG_TWIST_ALWAYS_EVALUATE_DEBUG_PRINTK) > #define pr_devel_once(fmt, ...) \
| |