Messages in this thread | | | Date | Sun, 24 May 2020 19:44:34 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 1/1] pwm: mtk_disp: implement .apply() |
| |
Hello,
On Fri, Apr 10, 2020 at 11:19:55AM +0800, Jitao Shi wrote: > implement the apply() for pwm. > > Fix the clock clk_prepare_enable and clk_disable_unprepare mismatch, > switch the driver to support the ->apply() method.
Adding support for get_state is a separate change.
Other than that this patch looks more complicated that I would expect, I think you can make this easier to understand/review by moving the mismatch to a separate patch, too.
Can you please respin with these hints in mind, then I'm willing to invest some time for a deeper review. In general it's very welcome to convert the mtk-disp driver to the atomic API. Thanks for addressing that.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
| |