Messages in this thread | | | Subject | Re: [PATCH] linux/blkdev.h: Use ilog2() directly in blksize_bits() | From | Jens Axboe <> | Date | Sat, 23 May 2020 12:50:03 -0600 |
| |
On 5/23/20 12:33 PM, Bart Van Assche wrote: > On 2020-05-23 08:50, Kaitao Cheng wrote: >> blksize_bits() can be achieved through ilog2(), and ilog2() is >> more efficient. > > If Jens agrees, how about removing the blksize_bits() function entirely > and to make all callers use ilog2() instead of blksize_bits()?
Yeah, if we are going this path, then let's just kill the function completely.
-- Jens Axboe
| |