Messages in this thread | | | Date | Sat, 23 May 2020 08:10:33 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2] firewire: Remove function callback casts |
| |
On Fri, May 22, 2020 at 07:43:08PM +0200, Oscar Carter wrote: > Hi, > > On Wed, May 20, 2020 at 03:16:24PM +0900, Takashi Sakamoto wrote: > > Hi, > > > > I'm an author of ALSA firewire stack and thanks for the patch. I agree with > > your intention to remove the cast of function callback toward CFI build. > > > > Practically, the isochronous context with FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL > > is never used by in-kernel drivers. Here, I propose to leave current > > kernel API (fw_iso_context_create() with fw_iso_callback_t) as is.
If it's not used by anyone, why is it still there? Can't we just delete it?
thanks,
greg k-h
| |