lkml.org 
[lkml]   [2020]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 3/3] x86/boot/compressed: get rid of GOT fixup code
    On Sat, May 23, 2020 at 02:00:21PM +0200, Ard Biesheuvel wrote:
    > In a previous patch, we have eliminated GOT entries from the decompressor
    > binary and added an assertion that the .got section is empty. This means
    > that the GOT fixup routines that exist in both the 32-bit and 64-bit
    > startup routines have become dead code, and can be removed.
    >
    > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
    > diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S
    > index 60a99dfb9d72..d91fdda51aa8 100644
    > --- a/arch/x86/boot/compressed/vmlinux.lds.S
    > +++ b/arch/x86/boot/compressed/vmlinux.lds.S
    > @@ -43,9 +43,7 @@ SECTIONS
    > _erodata = . ;
    > }
    > .got : {
    > - _got = .;
    > KEEP(*(.got))
    > - _egot = .;
    > }
    > .got.plt : {
    > KEEP(*(.got.plt))
    > --
    > 2.20.1
    >

    I think you can get rid of both the KEEP's here as well?

    \
     
     \ /
      Last update: 2020-05-23 17:19    [W:2.410 / U:1.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site