Messages in this thread | | | From | Alex Deucher <> | Date | Fri, 22 May 2020 13:54:01 -0400 | Subject | Re: [PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper |
| |
On Fri, May 22, 2020 at 1:46 PM Gustavo A. R. Silva <gustavoars@kernel.org> wrote: > > On Wed, May 20, 2020 at 09:42:27AM +0200, Christian König wrote: > > > > > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > > > Acked-by: Christian König <christian.koenig@amd.com> > > > > May I suggest that we add a section how to correctly do this to > > Documentation/process/coding-style.rst or similar document? > > > > That's already on my list. :) > > > I've seen a bunch of different approaches and some even doesn't work with > > some gcc versions and result in a broken binary. > > > > Do you have an example of that one that doesn't work with some GCC > versions? It'd be interesting to take a look...
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/radeon/radeon_atombios.c?id=a7ee824a6255e347ea76e2f00827e81bbe01004e
Alex
> > Thanks > -- > Gustavo > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
| |