Messages in this thread | | | Date | Fri, 22 May 2020 10:22:51 -0700 | From | Kees Cook <> | Subject | Re: [RFC PATCH 5/5] selftest/x86: Add CET quick test |
| |
On Fri, May 22, 2020 at 11:28:48AM +0200, Peter Zijlstra wrote: > Get asm/asm.h into userspace and then write something like:
Yeah, selftests is going to start suffering from the same "tools/ header duplication" problem. I've also had cases (see the logic in the Makefile in selftests/x86) where selftests is duplicating existing Kconfig and Makefile logic ("can I build this way?")
But yes, I think getting a copy of asm.h would be nice here. I don't think the WRITE_ONCE() is needed in this particular case. Hmm.
-- Kees Cook
| |