Messages in this thread | | | Subject | Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu() | From | shuah <> | Date | Fri, 22 May 2020 08:55:50 -0600 |
| |
On 5/19/20 11:44 AM, Mark Brown wrote: > On Tue, May 19, 2020 at 11:11:28AM -0600, shuah wrote: >> On 5/5/20 11:47 AM, Mark Brown wrote: > >>> +int main(int argc, char **argv) >>> +{ >>> + unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR); >> >> WARNING: Missing a blank line after declarations >> WARNING: Missing a blank line after declarations >> #135: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:27: >> + unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR);
A blank line after declarations here just like what checkpatch suggests. It makes it readable.
>> + if (!sysinfo_ehdr) { > > This is the idiom in use by the existing gettimeofday test: > > WARNING: Missing a blank line after declarations > #38: FILE: tools/testing/selftests/vDSO/vdso_test_gettimeofday.c:38: > + unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR); > + if (!sysinfo_ehdr) { > > so I don't know how you want the code to look here? >
See above.
thanks, -- Shuah
| |