lkml.org 
[lkml]   [2020]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 10/13] usb: gadget: legacy: fix redundant initialization warnings
    Date
    From: Masahiro Yamada <masahiroy@kernel.org>

    [ Upstream commit d13cce757954fa663c69845611957396843ed87a ]

    Fix the following cppcheck warnings:

    drivers/usb/gadget/legacy/inode.c:1364:8: style: Redundant initialization for 'value'. The initialized value is overwritten$
    value = -EOPNOTSUPP;
    ^
    drivers/usb/gadget/legacy/inode.c:1331:15: note: value is initialized
    int value = -EOPNOTSUPP;
    ^
    drivers/usb/gadget/legacy/inode.c:1364:8: note: value is overwritten
    value = -EOPNOTSUPP;
    ^
    drivers/usb/gadget/legacy/inode.c:1817:8: style: Redundant initialization for 'value'. The initialized value is overwritten$
    value = -EINVAL;
    ^
    drivers/usb/gadget/legacy/inode.c:1787:18: note: value is initialized
    ssize_t value = len, length = len;
    ^
    drivers/usb/gadget/legacy/inode.c:1817:8: note: value is overwritten
    value = -EINVAL;
    ^
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Reported-by: kbuild test robot <lkp@intel.com>
    Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
    Signed-off-by: Felipe Balbi <balbi@kernel.org>

    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/legacy/inode.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
    index 5c28bee327e1..e431a8bc3a9d 100644
    --- a/drivers/usb/gadget/legacy/inode.c
    +++ b/drivers/usb/gadget/legacy/inode.c
    @@ -1364,7 +1364,6 @@ gadgetfs_setup (struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl)

    req->buf = dev->rbuf;
    req->context = NULL;
    - value = -EOPNOTSUPP;
    switch (ctrl->bRequest) {

    case USB_REQ_GET_DESCRIPTOR:
    @@ -1788,7 +1787,7 @@ static ssize_t
    dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
    {
    struct dev_data *dev = fd->private_data;
    - ssize_t value = len, length = len;
    + ssize_t value, length = len;
    unsigned total;
    u32 tag;
    char *kbuf;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-05-22 16:52    [W:4.438 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site