Messages in this thread | | | Date | Thu, 21 May 2020 12:17:07 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature |
| |
On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: > This patchset adds two new VLAN feature. > > [patch 1] adds a new dynamic VLAN mode. > [patch 2] adds support for 'QoS' field to PVID. > > Change log: > V1->V2: modifies [patch 1]'s commit log, suggested by Jakub Kicinski.
I don't like the idea that FW is choosing the driver behavior in a way that's not observable via standard Linux APIs. This is the second time a feature like that posted for a driver this week, and we should discourage it.
| |