Messages in this thread | | | From | "Brown, Aaron F" <> | Subject | RE: [PATCH] e1000e: Disable TSO for buffer overrun workaround | Date | Thu, 21 May 2020 07:18:28 +0000 |
| |
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On > Behalf Of Kai-Heng Feng > Sent: Thursday, May 7, 2020 7:21 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com> > Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>; David S. Miller > <davem@davemloft.net>; Neftin, Sasha <sasha.neftin@intel.com>; Dima > Ruinskiy <dima.ruinskiy@intel.com>; Avargil, Raanan > <raanan.avargil@intel.com>; moderated list:INTEL ETHERNET DRIVERS <intel- > wired-lan@lists.osuosl.org>; open list:NETWORKING DRIVERS > <netdev@vger.kernel.org>; open list <linux-kernel@vger.kernel.org> > Subject: [PATCH] e1000e: Disable TSO for buffer overrun workaround > > Commit b10effb92e27 ("e1000e: fix buffer overrun while the I219 is > processing DMA transactions") imposes roughly 30% performance penalty. > > The commit log states that "Disabling TSO eliminates performance loss > for TCP traffic without a noticeable impact on CPU performance", so > let's disable TSO by default to regain the loss. > > Fixes: b10effb92e27 ("e1000e: fix buffer overrun while the I219 is processing > DMA transactions") > BugLink: https://bugs.launchpad.net/bugs/1802691 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++++ > 1 file changed, 4 insertions(+) Tested-by: Aaron Brown <aaron.f.brown@intel.com>
| |