Messages in this thread | | | Date | Thu, 21 May 2020 14:28:16 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events |
| |
Em Thu, May 21, 2020 at 10:26:02AM -0700, Ian Rogers escreveu: > On Thu, May 21, 2020 at 3:54 AM Jiri Olsa <jolsa@redhat.com> wrote: > > ok, I misunderstood and thought you would colaps also M3 to > > have A,B computed via M1 group and with separate D ... > > > > thanks a lot for the explanation, it might be great to have it > > in the comments/changelog or even man page > > Thanks Jiri! Arnaldo do you want me to copy the description above into > the commit message of this change and resend?
Send as a follow on patch, please.
- Arnaldo
> This patch adds some description to find_evsel_group, this is expanded > by the next patch that adds the two command line flags: > https://lore.kernel.org/lkml/20200520072814.128267-7-irogers@google.com/ > When writing the patches it wasn't clear to me how much detail to > include in say the man pages. > > Thanks, > Ian
| |