Messages in this thread | | | From | Saravana Kannan <> | Date | Thu, 21 May 2020 09:50:53 -0700 | Subject | Re: [PATCH v2 0/4] driver core: Add device link related sysfs files |
| |
On Thu, May 21, 2020 at 2:42 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Tue, May 19, 2020 at 08:48:20PM -0700, Saravana Kannan wrote: > > With fw_devlink and with sync_state() callback features, there's a lot > > of device/device link related information that's not available in sysfs. > > > > Exposing these details to user space can be very useful in understanding > > suspend/resume issues, runtime pm issues, probing issues, figuring out > > the modules that'd be needed for first stage init, etc. In fact, an > > earlier verion of this series was very helpful in debugging and > > validating the recent memory leak fix[1]. > > > > This series combines combines a bunch of patches I've sent before. > > > > I'm aware that I haven't added documentation for patch 1/2. I'm waiting > > on review to make sure the file location, name and values don't change > > before I add the documentation. > > You mean patch 2/4, right?
Yes.
> > This series is based on driver-core-next and [1] cherry-picked on top of > > it. > > I've taken patch 1 now, as it was easy to review :) > > I'll wait for the next series with the documentation update before going > further.
:( I was hoping I'll get an "okay" on where I expose the files, their names and content, etc before I document it. I'll add documentation now.
-Saravana
| |