Messages in this thread | | | Date | Thu, 21 May 2020 19:42:56 +0800 (GMT+08:00) | From | dinghao.liu@zju ... | Subject | Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error |
| |
We need to make sure if pm_runtime_get_sync() is designed with such behavior before modifying it.
I received a response from Rafael when I commited a similar patch: https://lkml.org/lkml/2020/5/20/1100 It seems that this behavior is intentional and needs to be kept.
Regards, Dinghao
"Dan Carpenter" <dan.carpenter@oracle.com>写道: > On Thu, May 21, 2020 at 02:27:45PM +0800, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > > the call returns an error code. Thus a pairing decrement is needed > > on the error handling path to keep the counter balanced. > > > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > > Let's stop working around the bug in pm_runtime_get_sync() and write > a replacement for it instead. > > regards, > dan carpenter
| |