lkml.org 
[lkml]   [2020]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error
On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao.liu@zju.edu.cn wrote:
> Hi, Dan,
>
> I agree the best solution is to fix __pm_runtime_resume(). But there are also
> many cases that assume pm_runtime_get_sync() will change PM usage
> counter on error. According to my static analysis results, the number of these
> "right" cases are larger. Adjusting __pm_runtime_resume() directly will introduce
> more new bugs. Therefore I think we should resolve the "bug" cases individually.
>

That's why I was saying that we may need to introduce a new replacement
function for pm_runtime_get_sync() that works as expected.

There is no reason why we have to live with the old behavior.

regards,
dan carpenter

\
 
 \ /
  Last update: 2020-05-21 11:39    [W:0.070 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site