Messages in this thread | | | Date | Wed, 20 May 2020 21:40:07 -0700 | From | Andrew Morton <> | Subject | Re: [RFC PATCH 2/2] init: Allow multi-line output of kernel command line |
| |
On Thu, 21 May 2020 13:36:28 +0900 Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> On (20/05/20 18:00), Andrew Morton wrote: > [..] > > I'm wondering if we shold add a kernel puts() (putsk()? yuk) which can > > puts() a string of any length. > > > > I'm counting around 150 instances of printk("%s", ...) and pr_foo("%s", > > ...) which could perhaps be converted, thus saving an argument. > > Can you point me at some examples? >
./arch/powerpc/kernel/udbg.c: printk("%s", s); ./arch/powerpc/xmon/nonstdio.c: printk("%s", xmon_outbuf); ./arch/um/os-Linux/drivers/ethertap_user.c: printk("%s", output); ./arch/um/os-Linux/drivers/ethertap_user.c: printk("%s", output); ./arch/um/os-Linux/drivers/tuntap_user.c: printk("%s", out
etc.
My point is, if we created a length-unlimited puts() function for printing the kernel command line, it could be reused in such places, resulting in a smaller kernel.
| |