lkml.org 
[lkml]   [2020]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice
    From
    Date
    On 5/21/20 10:42 AM, Ira Weiny wrote:
    > On Thu, May 21, 2020 at 09:05:41AM -0700, Guenter Roeck wrote:
    >> On 5/19/20 10:13 PM, Ira Weiny wrote:
    >>> On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote:
    >>>> On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote:
    >>>>> On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote:
    >>>>>> On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote:
    >>>>>>> From: Ira Weiny <ira.weiny@intel.com>
    >>>>>>>
    >>>>>>> The kunmap_atomic clean up failed to remove one set of pagefault/preempt
    >>>>>>> enables when vaddr is not in the fixmap.
    >>>>>>>
    >>>>>>> Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code")
    >>>>>>> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
    >>>>>>
    >>>>>> microblazeel works with this patch,
    >>>>>
    >>>>> Awesome... Andrew in my rush yesterday I should have put a reported by on the
    >>>>> patch for Guenter as well.
    >>>>>
    >>>>> Sorry about that Guenter,
    >>>>
    >>>> No worries.
    >>>>
    >>>>> Ira
    >>>>>
    >>>>>> as do the nosmp sparc32 boot tests,
    >>>>>> but sparc32 boot tests with SMP enabled still fail with lots of messages
    >>>>>> such as:
    >>>>>>
    >>>>>> BUG: Bad page state in process swapper/0 pfn:006a1
    >>>>>> page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1
    >>>>>> flags: 0x0()
    >>>>>> raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000
    >>>>>> page dumped because: nonzero mapcount
    >>>>>> Modules linked in:
    >>>>>> CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1
    >>>>>> [f00e7ab8 :
    >>>>>> bad_page+0xa8/0x108 ]
    >>>>>> [f00e8b54 :
    >>>>>> free_pcppages_bulk+0x154/0x52c ]
    >>>>>> [f00ea024 :
    >>>>>> free_unref_page+0x54/0x6c ]
    >>>>>> [f00ed864 :
    >>>>>> free_reserved_area+0x58/0xec ]
    >>>>>> [f0527104 :
    >>>>>> kernel_init+0x14/0x110 ]
    >>>>>> [f000b77c :
    >>>>>> ret_from_kernel_thread+0xc/0x38 ]
    >>>>>> [00000000 :
    >>>>>> 0x0 ]
    >>>>>>
    >>>>>> Code path leading to that message is different but always the same
    >>>>>> from free_unref_page().
    >>>
    >>> Actually it occurs to me that the patch consolidating kmap_prot is odd for
    >>> sparc 32 bit...
    >>>
    >>> Its a long shot but could you try reverting this patch?
    >>>
    >>> 4ea7d2419e3f kmap: consolidate kmap_prot definitions
    >>>
    >>
    >> That is not easy to revert, unfortunately, due to several follow-up patches.
    >
    > I have gotten your sparc tests to run and they all pass...
    >
    > 08:10:34 > ../linux-build-test/rootfs/sparc/run-qemu-sparc.sh
    > Build reference: v5.7-rc4-17-g852b6f2edc0f
    >

    That doesn't look like it is linux-next, which I guess means that something
    else in linux-next breaks it. What is your qemu version ?

    Thanks,
    Guenter

    > Building sparc32:SPARCClassic:nosmp:scsi:hd ... running ......... passed
    > Building sparc32:SPARCbook:nosmp:scsi:cd ... running ......... passed
    > Building sparc32:LX:nosmp:noapc:scsi:hd ... running ......... passed
    > Building sparc32:SS-4:nosmp:initrd ... running ......... passed
    > Building sparc32:SS-5:nosmp:scsi:hd ... running ......... passed
    > Building sparc32:SS-10:nosmp:scsi:cd ... running ......... passed
    > Building sparc32:SS-20:nosmp:scsi:hd ... running ......... passed
    > Building sparc32:SS-600MP:nosmp:scsi:hd ... running ......... passed
    > Building sparc32:Voyager:nosmp:noapc:scsi:hd ... running ......... passed
    > Building sparc32:SS-4:smp:scsi:hd ... running ......... passed
    > Building sparc32:SS-5:smp:scsi:cd ... running ......... passed
    > Building sparc32:SS-10:smp:scsi:hd ... running ......... passed
    > Building sparc32:SS-20:smp:scsi:hd ... running ......... passed
    > Building sparc32:SS-600MP:smp:scsi:hd ... running ......... passed
    > Building sparc32:Voyager:smp:noapc:scsi:hd ... running ......... passed
    >
    > Is there another test I need to run?
    >
    > Ira
    >
    >
    >>
    >> Guenter
    >>
    >>> Alternately I will need to figure out how to run the sparc on qemu here...
    >>>
    >>> Thanks very much for all the testing though! :-D
    >>>
    >>> Ira
    >>>
    >>>>>>
    >>>>>> Still testing ppc images.
    >>>>>>
    >>>>
    >>>> ppc image tests are passing with this patch.
    >>>>
    >>>> Guenter
    >>

    \
     
     \ /
      Last update: 2020-05-22 00:28    [W:6.102 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site