lkml.org 
[lkml]   [2020]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
Date
> From: Dan Williams
> > Sent: 20 May 2020 16:26
> ...
> > > > +#ifdef CONFIG_ARCH_HAS_COPY_MC
> > > > +extern unsigned long __must_check
> > >
> > > We try not to add extern in headers anymore.
> >
> > Ok, I was doing the copy-pasta dance, but I'll remove this.
>
> It is data not code, it needs the extern to not be 'common'.
> OTOH what is a global variable being used for?

Aaarg not enough context...

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
\
 
 \ /
  Last update: 2020-05-20 17:35    [W:0.037 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site