Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 20 May 2020 16:51:30 +0200 | Subject | Re: [PATCH] sh: include linux/time_types.h for sockios |
| |
Hi Arnd,
On Wed, May 20, 2020 at 4:46 PM Arnd Bergmann <arnd@arndb.de> wrote: > On Wed, May 20, 2020 at 1:47 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Wed, May 20, 2020 at 10:32 AM Arnd Bergmann <arnd@arndb.de> wrote: > > > On Wed, May 20, 2020 at 3:10 AM Andrew Morton <akpm@linux-foundation.org> wrote: > > > > On Tue, 19 May 2020 15:13:13 +0200 Arnd Bergmann <arnd@arndb.de> wrote: > > > > > Using the socket ioctls on arch/sh (and only there) causes build > > > > > time problems when __kernel_old_timeval/__kernel_old_timespec are > > > > > not already visible to the compiler. > > > > > > > > > > Add an explict include line for the header that defines these > > > > > structures. > > > > > > > > I can grab this. > > > > > > Thanks! > > > > > > > > Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > > > > > Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > > > > > Fixes: 8c709f9a0693 ("y2038: sh: remove timeval/timespec usage from headers") > > > > > Fixes: 0768e17073dc ("net: socket: implement 64-bit timestamps") > > > > > > > > cc:stable? > > > > > > Yes, I missed that. > > > > Doesn't matter, the stable bots will pick it up anyway, based on the Fixes tag. > > I normally prefer to be explicit, as some bug fixes may address > something that has been caused by an earlier commit, but should not > be backported for some reason.
Which means that with the current "intelligent' backporting, you need a Not-for-stable tag instead...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |