lkml.org 
[lkml]   [2020]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 46/99] power: supply: sbs-battery: Fix a signedness bug in sbs_get_battery_capacity()
    3.16.84-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit eb368de6de32925c65a97c1e929a31cae2155aee upstream.

    The "mode" variable is an enum and in this context GCC treats it as an
    unsigned int so the error handling is never triggered.

    Fixes: 51d075660457 ("bq20z75: Add support for charge properties")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
    [bwh: Backported to 3.16: adjust filename, context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/power/sbs-battery.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/power/sbs-battery.c
    +++ b/drivers/power/sbs-battery.c
    @@ -400,7 +400,7 @@ static int sbs_get_battery_capacity(stru
    mode = BATTERY_MODE_AMPS;

    mode = sbs_set_battery_mode(client, mode);
    - if (mode < 0)
    + if ((int)mode < 0)
    return mode;

    ret = sbs_read_word_data(client, sbs_data[reg_offset].addr);
    \
     
     \ /
      Last update: 2020-05-20 16:28    [W:4.091 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site