Messages in this thread | | | Date | Wed, 20 May 2020 13:31:35 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 09/12] devfreq: add mediatek cci devfreq |
| |
On Wed, May 20, 2020 at 11:43:04AM +0800, Andrew-sh.Cheng wrote:
> + cci_df->proc_reg = devm_regulator_get_optional(cci_dev, "proc"); > + ret = PTR_ERR_OR_ZERO(cci_df->proc_reg); > + if (ret) { > + if (ret != -EPROBE_DEFER) > + dev_err(cci_dev, "failed to get regulator for CCI: %d\n", > + ret); > + return ret; > + } > + ret = regulator_enable(cci_df->proc_reg);
The code appears to require a regulator (and I'm guessing the device needs power) so why is this using regulator_get_optional()? [unhandled content-type:application/pgp-signature] | |