Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] of: drop a reference on error in __of_attach_node_sysfs() | Date | Wed, 20 May 2020 20:06:39 +1000 |
| |
Dan Carpenter <dan.carpenter@oracle.com> writes: > We add a new of_node_get() to this function, but we should drop the > reference if kobject_add(). ^ fails? > > Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in __of_attach_node_sysfs") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > From static analysis. Maybe we should just call of_node_get() right > before we return 0?
Yeah that would be simpler and equally correct AFAICS.
cheers
> diff --git a/drivers/of/kobj.c b/drivers/of/kobj.c > index c72eef988041..a90dc4b3b060 100644 > --- a/drivers/of/kobj.c > +++ b/drivers/of/kobj.c > @@ -138,8 +138,10 @@ int __of_attach_node_sysfs(struct device_node *np) > > rc = kobject_add(&np->kobj, parent, "%s", name); > kfree(name); > - if (rc) > + if (rc) { > + of_node_put(np); > return rc; > + } > > for_each_property_of_node(np, pp) > __of_add_property_sysfs(np, pp); > -- > 2.26.2
| |