lkml.org 
[lkml]   [2020]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value
    From
    Date
    Hi,

    On 19.05.2020 23:25, Łukasz Stelmach wrote:
    > The value was estimaded with ea_iid[1] using on 10485760 bytes read from
    > the RNG via /dev/hwrng. The min-entropy value calculated using the most
    > common value estimate (NIST SP 800-90P[2], section 6.3.1) was 7.964464.
    >
    > [1] https://protect2.fireeye.com/url?k=316f3d79-6cf9840e-316eb636-0cc47a312ab0-5f119f729b3ddc11&q=1&u=https%3A%2F%2Fgithub.com%2Fusnistgov%2FSP800-90B_EntropyAssessment

    This link looks ugly and do not protect anything.
    Can you just cut out that "protect2" thing and put proper direct link to github ?

    > [2] https://csrc.nist.gov/publications/detail/sp/800-90b/final
    >
    > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
    > ---
    > drivers/char/hw_random/iproc-rng200.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
    > index 32d9fe61a225..95669ece050f 100644
    > --- a/drivers/char/hw_random/iproc-rng200.c
    > +++ b/drivers/char/hw_random/iproc-rng200.c
    > @@ -199,6 +199,7 @@ static int iproc_rng200_probe(struct platform_device *pdev)
    > priv->rng.read = iproc_rng200_read,
    > priv->rng.init = iproc_rng200_init,
    > priv->rng.cleanup = iproc_rng200_cleanup,
    > + priv->rng.quality = 1000,
    >
    > /* Register driver */
    > ret = devm_hwrng_register(dev, &priv->rng);
    >

    --
    Best regards,
    Kamil Konieczny
    Samsung R&D Institute Poland

    \
     
     \ /
      Last update: 2020-05-20 10:19    [W:3.595 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site