lkml.org 
[lkml]   [2020]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema
Date


> Subject: RE: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema
>
> > From: Anson Huang <Anson.Huang@nxp.com>
> > Sent: Wednesday, May 20, 2020 2:03 PM
> >
> > Convert the i.MX thermal binding to DT schema format using json-schema
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > Changes since V1:
> > - move tempmon node into its parent node anatop in example;
> > - improve "fsl,tempmon" description.
> > ---
> > .../devicetree/bindings/thermal/imx-thermal.txt | 61 -------------
> > .../devicetree/bindings/thermal/imx-thermal.yaml | 100
>
> [...]
>
> > +title: NXP i.MX Thermal Binding
> > +
> > +maintainers:
> > + - Shawn Guo <shawn.guo@linaro.org>
> > + - Anson Huang <Anson.Huang@nxp.com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
>
> Drop Unnecessary properties

Will use enum directly.

>
> > + - enum:
> > + - fsl,imx6q-tempmon
> > + - fsl,imx6sx-tempmon
> > + - fsl,imx7d-tempmon
> > +
> > + interrupts:
> > + description: |
> > + The interrupt output of the controller, the IRQ will be triggered
> > + when temperature is higher than high threshold.
> > + maxItems: 1
>
> You'd better explain why interrupts number is changed in the new binding
> compared to the original one. Probably add in commit message if really
> needed.

There is ONLY 1 interrupt output from temperature to GIC, some platforms like
i.MX6SX/i.MX7D has 2 more secondary interrupts inside anatop which shares same output
interrupt to GIC, these 2 interrupts are NOT used for now, so from the high level
description of the interrupt, should be ONLY 1 interrupt item I think.

>
> > +
> > + nvmem-cells:
> > + description: |
> > + Phandle to the calibration cells provided by ocotp for calibration
> > + data and temperature grade.
>
> Better describe for each of them as you did for clocks

Will do in V3.

>
> > + maxItems: 2
> > +
> > + nvmem-cell-names:
> > + maxItems: 2
> > + items:
> > + - const: calib
> > + - const: temp_grade
> > +
> > + fsl,tempmon:
> > + $ref: '/schemas/types.yaml#/definitions/phandle'
> > + description: Phandle to the register map node.
>
> What register map? A bit ambiguous..

Temperature sensor registers, will add more detail in V3.

Anson

\
 
 \ /
  Last update: 2020-05-20 10:05    [W:0.047 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site