Messages in this thread | | | Subject | Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata() | From | Peter Ujfalusi <> | Date | Wed, 20 May 2020 10:08:54 +0300 |
| |
On 06/05/2020 11.43, Jason Yan wrote: > > > 在 2020/5/6 16:29, Russell King - ARM Linux admin 写道: >> On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote: >>> Fix the following coccicheck warning: >>> >>> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return >>> "0" on line 161 >> >> NAK. Look closer at what the code is doing, thanks. >> >> This warning is basically incorrect. >> > > OK, the macro SET_DMA_ERRATA is using this variable.
How can a patch from you can be trusted if you did not even try to compile-test? Please try to _test_ your changes before sending, or add a disclaimer that it might not even compile.
Thanks, - Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki [unhandled content-type:application/pgp-keys]
| |