Messages in this thread | | | Subject | Re: [PATCH v2 1/1] dt-bindings: spi: Add schema for Cadence QSPI Controller driver | From | "Ramuthevar, Vadivel MuruganX" <> | Date | Thu, 21 May 2020 10:18:26 +0800 |
| |
Hi Mark,
Thank you for the review comments...
On 20/5/2020 8:43 pm, Mark Brown wrote: > On Wed, May 20, 2020 at 08:36:12PM +0800, Ramuthevar,Vadivel MuruganX wrote: >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >> >> Add dt-bindings documentation for Cadence-QSPI controller to support >> spi based flash memories. >> >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >> --- >> .../devicetree/bindings/mtd/cadence-quadspi.txt | 67 ----------- >> .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 133 +++++++++++++++++++++ > > The changelog says this is adding a new binding but the actual change is > mostly a conversion to YAML. Please split the additions out into a > separate change, ideally doing that before the conversion since there is > a backlog on review of YAML conversions.
Initially was sending the only YAML file alone, then reviewers suggest to me do this way so I did, next by split the patches like below...
1. remove the cadence-quadspi.txt (patch1) 2. convert txt to YAML (patch2)
Regards Vadivel >
| |