Messages in this thread | | | Date | Wed, 20 May 2020 20:39:13 -0300 | From | Marcelo Ricardo Leitner <> | Subject | Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay |
| |
On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be a bit more complete than that. > > The APIs are being designed based upon what in-tree users actually > make use of. We can expand things later if necessary.
Sometimes expanding things later can be though, thus why the worry. But ok, I get it. Thanks.
The comment still applies, though. (re the duplication)
| |