Messages in this thread | | | From | Avri Altman <> | Subject | RE: [PATCH v4 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling | Date | Wed, 20 May 2020 21:33:37 +0000 |
| |
Hi,
> > > Qualcomm controller needs to be in hibern8 before scaling clocks. > This change puts the controller in hibern8 state before scaling > and brings it out after scaling of clocks. > > Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
I guess that your previous versions are pretty far back - , I noticed a comment by Pedro, so you might want to resend this series.
What happens if the pre-change is successful, but you are not getting to the post change because, e.g. ufshcd_set_clk_freq failed?
Also, this piece of code is ~5 years old, so you might want to elaborate on how come hibernation is now needed.
Thanks, Avri
| |