Messages in this thread | | | Date | Wed, 20 May 2020 21:27:19 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869 |
| |
Hi Dan
> UGH I think I just got volunteered to do make them common.
There is code you can copy from PHY drivers. :-)
What would be kind of nice is if the validate was in the core as well. Pass a list of possible delays in pS, and it will do a phydev_err() if what is in DT does not match one of the listed delays. Take a look around at what current drivers do and see if you can find a nice abstraction which will work for a few drivers. We cannot easily convert existing drivers without breaking DT, but a design which works in theory for what we currently have has a good chance of working for any new PHY driver.
Andrew
| |