Messages in this thread | | | Date | Sat, 02 May 2020 16:33:50 -0700 (PDT) | Subject | Re: [PATCH] stmmac: fix pointer check after utilization in stmmac_interrupt | From | David Miller <> |
| |
From: Maxim Petrov <mmrmaximuzz@gmail.com> Date: Sat, 2 May 2020 12:29:08 +0300
> The paranoidal pointer check in IRQ handler looks very strange - it > really protects us only against bogus drivers which request IRQ line > with null pointer dev_id. However, the code fragment is incorrect > because the dev pointer is used before the actual check. That leads > to undefined behavior thus compilers are free to remove the pointer > check at all. > > Signed-off-by: Maxim Petrov <mmrmaximuzz@gmail.com>
Seriously, just remove this check altogether.
| |