Messages in this thread | | | Date | Tue, 19 May 2020 20:17:13 +0200 | From | Domenico Andreoli <> | Subject | Re: [PATCH 1/1] hibernate: restrict writes to the snapshot device |
| |
On Tue, May 19, 2020 at 05:59:15PM +0200, Rafael J. Wysocki wrote: > It would be better to paste the patch instead of attaching it.
Done with v2.
> Anyway, note that the snapshot special device is not the target block > device for saving the image, so it would be good to avoid that > confusion in the naming.
I realize that it was a bit hazy in my head as well. It should be fixed in v2.
> > I.e. I would rename is_hibernate_snapshot_dev() to something like > is_hibernate_image_dev() or is_hibernate_resume_dev() (for consistency > with the resume= kernel command line parameter name).
Done as well.
> Thanks!
Thank you!
Dom
-- rsa4096: 3B10 0CA1 8674 ACBA B4FE FCD2 CE5B CF17 9960 DE13 ed25519: FFB4 0CC3 7F2E 091D F7DA 356E CC79 2832 ED38 CB05
| |